Skip to content

Commit c18d40d

Browse files
committed
Document that summary's order should be compatible
At time of writing, I'm not sure about the exact relationship here, but there definitely ought to be one!
1 parent 043ef73 commit c18d40d

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

timely/src/progress/reachability.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ impl<T: Timestamp> Builder<T> {
205205
Tracker::allocate_from(self, logger)
206206
}
207207

208-
/// Tests whether the graph a cycle of default path summaries.
208+
/// Tests whether the graph includes a cycle of default path summaries.
209209
///
210210
/// Graphs containing cycles of default path summaries will most likely
211211
/// not work well with progress tracking, as a timestamp can result in

timely/src/progress/timestamp.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ pub trait PathSummary<T> : Clone+'static+Eq+PartialOrder+Debug+Default {
3131
/// in computation, uses this method and will drop messages with timestamps that when advanced
3232
/// result in `None`. Ideally, all other timestamp manipulation should behave similarly.
3333
///
34+
/// This summary's partial order is expected to be compatible with the partial order of [T],
35+
/// in the sense that if `s1.less_equal(s2)`, then `s1.results_in(&t)` is less than or equal to
36+
/// `s2.results_in(&t)`.
37+
///
3438
/// Note that `Self::default()` is expected to behave as an "empty" or "noop" summary, such that
3539
/// `Self::default().results_in(&t) == Some(t)`.
3640
///

0 commit comments

Comments
 (0)