Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert sfx to opus and switch from html5 to webaudio api #12

Open
Timtam opened this issue Aug 5, 2024 · 0 comments
Open

convert sfx to opus and switch from html5 to webaudio api #12

Timtam opened this issue Aug 5, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
Release 1.0 (firs...

Comments

@Timtam
Copy link
Owner

Timtam commented Aug 5, 2024

Howler is unable to play MP3 via WebAudio, but HTML5 will prevent FX like panning from being applied. We thus will need to convert SFX from mp3 to opus and use WebAudio API over HTML5 for SFX (not hits).
@Timtam Timtam added the enhancement New feature or request label Aug 5, 2024
Timtam added a commit that referenced this issue Aug 5, 2024
@Timtam
add events to selecting slots (panning not yet working thanks to mp3'…
43ab026 
…s in html5 mode, see #12)
Timtam added a commit that referenced this issue Aug 5, 2024
@Timtam
convert mp3 sfx to opus and use web audio instead of html5 to play th…
85af25a 
…em (closes #12)
Timtam added a commit that referenced this issue Aug 7, 2024
@Timtam
merged a huge portion of keystrokes support
d412d60 
Squashed commit of the following:

commit 9c65f1c
Author: Toni Barth <[email protected]>
Date:   Wed Aug 7 15:29:15 2024 +0200

    add keystrokes for confirming

commit 17919d8
Author: Toni Barth <[email protected]>
Date:   Wed Aug 7 15:04:09 2024 +0200

    map alt + keystrokes to alt+shift instead
    decide against hiding the aria-live control to allow for instant speech feedback

commit 720fe1e
Author: Toni Barth <[email protected]>
Date:   Wed Aug 7 14:12:46 2024 +0200

    add key shortcuts for resetting slot and submitting guess

commit 65183a9
Author: Toni Barth <[email protected]>
Date:   Wed Aug 7 00:12:43 2024 +0200

    squash multiple CI fixes
    [skip ci]

commit 0f6c5f9
Merge: e53bb1a eb8b045
Author: Toni Barth <[email protected]>
Date:   Tue Aug 6 13:46:28 2024 +0200

    Merge branch 'main' into h2-keystrokes

commit e53bb1a
Author: Toni Barth <[email protected]>
Date:   Mon Aug 5 23:25:05 2024 +0200

    add alt + shift + arrow up / down to cycle between slots on slot selector

commit ade50a5
Merge: 43ab026 e5ba859
Author: Toni Barth <[email protected]>
Date:   Mon Aug 5 19:45:16 2024 +0200

    Merge branch 'development' into h2-keystrokes

    # Conflicts:
    #	client/src/pages/game.tsx

commit 43ab026
Author: Toni Barth <[email protected]>
Date:   Mon Aug 5 19:21:53 2024 +0200

    add events to selecting slots (panning not yet working thanks to mp3's in html5 mode, see #12)

commit aec187f
Author: Toni Barth <[email protected]>
Date:   Sun Aug 4 22:46:02 2024 +0200

    add keystrokes to join and leave a game

commit 2e8945c
Author: Toni Barth <[email protected]>
Date:   Sun Aug 4 15:44:31 2024 +0200

    add useModalShown hook to check if a modal is currently open and use that to disable keystrokes when a modal is currently shown

commit f33f456
Author: Toni Barth <[email protected]>
Date:   Sun Aug 4 14:31:57 2024 +0200

    shortcuts to start public, private and local game in lobby

commit 5b8c75b
Author: Toni Barth <[email protected]>
Date:   Sat Aug 3 22:12:36 2024 +0200

    add keystroke for starting and stopping the game
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 1.0 (first official release)
Development

No branches or pull requests
1 participant
@Timtam