-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI build is broken #297
Comments
Hi @kazimuth , yes indeed. If we use the new Halide (and not our fork of Halide which is a bit old), that would solve the problem. On one of our internal machines, Tiramisu works fine with a new Halide, but I just did not have time to propagate the change to CI. If you are interested in helping on that I can give you assistance and we can try. |
I might be able to pick that up, sure. I'm contemplating using Tiramisu for some MIT coursework this semester, but to do that I'll need a functioning build on my machine :) |
Oh Ok I see. That one is independent though. You should be able to compile and use Tiramisu without a problem. The problem that we have with CI is only related to a mismatch in the LLVM versions we are using or something. There is a PR that tries to address that, but I still didn't have time to test it. Go ahead and just install Tiramisu on your machine and let us know if you have a problem. If you get a problem I'll be happy to help you out. |
Yeah, I was running into the same problem cause I was trying to avoid recompiling LLVM lol. Will do. |
Ok, here is the solution then:
In principle, if you get a fresh Halide from the halide repo, that one is good. The Halide that we have is a bit old and does not have the fix to avoid the problem you specified. |
Let me know if this works for you. |
Compiling old LLVM and halide works fine. Using current halide gives a few compile errors; they seem fixable, though. I might take a shot at patching them over the weekend. |
Ok this is perfect! So if I understood well, you problem is solved now? You want to patch the old Halide or the new one? |
I think it would be possible to just patch tiramisu to use the new halide. Most of the changes seem to be small changes to function signatures, unless there have been any major underlying architecture changes in Halide I'm not seeing. |
In theory, even Tiramisu should not be modified. It should work with the new Halide without a change. Only the github submodule pointer has to point to the public halide instead of pointing to the current outdated Halide. I have tried before to make it work with the new Halide and it just worked with the need to change Tiramisu so it should be fine! (unless I'm missing something) |
Hm, there seem to be some compilation errors? Changed signatures and stuff, with the most recent halide release. |
Sorry which errors are you referring to?
…On Sun, Sep 8, 2019, 2:23 PM James Gilles ***@***.***> wrote:
Hm, there seem to be some compilation errors? Changed signatures and
stuff, with the most recent halide release.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#297?email_source=notifications&email_token=ACL32NCK34EJMDI5CNMLP2LQIVGJVA5CNFSM4IT7Z7N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FXOGQ#issuecomment-529233690>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACL32NBCUEKVKYNYO7NTMQDQIVGJVANCNFSM4IT7Z7NQ>
.
|
Are there new errors compared to those I reported? #217 (note that I didn't try to build Tiramisu with Halide master) |
The CI build is failing. It seems to have something to do with halide's ABI not matching LLVM's, not sure how to fix that.
The text was updated successfully, but these errors were encountered: