Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: rename GET_NODES and SEND_NODES packet types #2832

Closed
Green-Sky opened this issue Jan 15, 2025 · 0 comments · Fixed by #2860
Closed

cleanup: rename GET_NODES and SEND_NODES packet types #2832

Green-Sky opened this issue Jan 15, 2025 · 0 comments · Fixed by #2860
Labels
chore Updating grunt tasks etc; no production code change
Milestone
v0.2.21

Comments

@Green-Sky
Copy link
Member

Green-Sky commented Jan 15, 2025 •
edited
Loading

... to NODES_REQUEST and NODES_RESPONSE, as declared in the spec.

c-toxcore/toxcore/network.h

Lines 115 to 116 in 05abe08

NET_PACKET_GET_NODES = 0x02, /* Get nodes request packet ID. */
NET_PACKET_SEND_NODES_IPV6 = 0x04, /* Send nodes response packet ID for other addresses. */

And remember to update the profiler.

Discovered while implementing #1885
@Green-Sky Green-Sky added this to the v0.2.22 milestone Jan 15, 2025
@Green-Sky Green-Sky added the chore Updating grunt tasks etc; no production code change label Jan 15, 2025
@Green-Sky Green-Sky modified the milestones: v0.2.22, v0.2.21 Feb 3, 2025
@Green-Sky Green-Sky changed the title chore: rename GET_NODES and SEND_NODES packet types cleanup: rename GET_NODES and SEND_NODES packet types Feb 3, 2025
@Green-Sky Green-Sky mentioned this issue Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Updating grunt tasks etc; no production code change
Milestone
v0.2.21
Development

Successfully merging a pull request may close this issue.

cleanup: rename getnodes/sendnodes to nodes request/response Green-Sky/c-toxcore
1 participant
@Green-Sky