Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tokens optimistically added to Wallet #231

Open
acnebs opened this issue Dec 8, 2021 · 5 comments
Open

New Tokens optimistically added to Wallet #231

acnebs opened this issue Dec 8, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@acnebs
Copy link
Contributor

acnebs commented Dec 8, 2021

When you create a new token, it would probably be nice if that token immediately appears in your wallet, with some interface elements to signify that the token is actually pending confirmation (and therefore if confirmation fails it will disappear). This is arguably better UX than just having the user wait an indeterminate amount of time until the transaction confirms for it to show up in their wallet (or never show up at all, even more confusing).

@acnebs acnebs added the enhancement New feature or request label Dec 8, 2021
@acnebs
Copy link
Contributor Author

acnebs commented Dec 8, 2021

@lenilsonjr isn't sure about this. But given how we are already straying from the blockchain being the absolute source of truth that we just mirror, I think it's probably fine.

@lenilsonjr
Copy link
Contributor

Having slept on it, if we mark those as pending in the UI, I think this is totally desirable. Thanks for raising.

@acnebs
Copy link
Contributor Author

acnebs commented Dec 8, 2021

Great, I will look into adding this as part of my transaction improvements.

@acnebs acnebs self-assigned this Dec 8, 2021
@NutellaLicka
Copy link
Contributor

NutellaLicka commented Dec 12, 2021

I am also of the opinion that an optimisation in UX is fine for this, as long as we label it as pending and stop them from interacting with the token until it is actually seen on the blockchain and is confirmed (>2 confirmations required to ensure it has been dPoW'd and not a part of some reorg). This gives the user a good feedback loop that what they have just created is actually doing something in the background.

@acnebs
Copy link
Contributor Author

acnebs commented Dec 12, 2021

Won't it need to be ~10 confirms to ensure it's been dPoW'd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants