Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Schedule #1

Open
3 of 7 tasks
TomMaullin opened this issue Dec 16, 2022 · 1 comment
Open
3 of 7 tasks

Release Schedule #1

TomMaullin opened this issue Dec 16, 2022 · 1 comment

Comments

@TomMaullin
Copy link
Owner

TomMaullin commented Dec 16, 2022

To convert the code in it's current state into a working toolbox the following steps must be enacted:

  • Rehaul: All code must be restructured into user-friendly functions and the repo must meet pip guidelines.
  • Testing: Unit tests must be written for all functions and continuous integration must be established.
  • Profiling: Once the above have been done, everything will be very slow. Extensive profiling will be needed to resolve this. It is likely as well that speed improvements can be made for the single excursion setting.
  • 3D: All code must be extended to work in 3D and then NIFTI input must be considered. Memory management must then be handled.
  • Simulations: The rehaul will have destroyed time efficiency for the simulation scripts (which largely relied on running many analyses concurrently for speed). In addition, many of the simulation scripts required obscure tweaks to the codebase which shouldn't be included in a user-end version of the code as they would be redundant (e.g. tests of variants which performed worse etc). These will have to be rewritten entirely.
  • Cohen's d: Once everything else is done, we can implement Cohen's d.
  • CRs for peaks: Once all of the above is done, peaks can be implemented.
@TomMaullin
Copy link
Owner Author

Update: Following PR #2 there are now Cohen's D CRs implemented, as well as a major rehaul of the code and 3D implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant