From 1e9f1f43a738f1d47ecc8818cd55da3d7b1921bf Mon Sep 17 00:00:00 2001
From: Tom Schimansky <tomschimansk@gmail.com>
Date: Fri, 12 Feb 2021 00:18:57 +0100
Subject: [PATCH] readme changes

---
 README.md                                     |   2 ++
 ...TunerDesign.icns => GuitarTuner_Icon.icns} | Bin
 setup.py                                      |  21 +++++++++---------
 3 files changed, 13 insertions(+), 10 deletions(-)
 rename assets/images/{GuitarTunerDesign.icns => GuitarTuner_Icon.icns} (100%)

diff --git a/README.md b/README.md
index 9cf1e12..e40f797 100644
--- a/README.md
+++ b/README.md
@@ -5,6 +5,8 @@ The played note is automatically recognized through the microphone, and an acous
 heard when the tuning is correct. If you want you can also change the reference-tone to another
 frequency.
 
+**Download macOS app:** https://github.com/TomSchimansky/GuitarTuner/releases/tag/3.0
+
 ### Functionality
 
 The app uses PyAudio to get access to the raw audio-stream coming from the microphone.
diff --git a/assets/images/GuitarTunerDesign.icns b/assets/images/GuitarTuner_Icon.icns
similarity index 100%
rename from assets/images/GuitarTunerDesign.icns
rename to assets/images/GuitarTuner_Icon.icns
diff --git a/setup.py b/setup.py
index ee77d35..072457e 100644
--- a/setup.py
+++ b/setup.py
@@ -1,16 +1,14 @@
-"""
-For Compilation MacOS you can do:
-
-pip3 install -r requirements.txt
-python3 setup.py py2app
-
-"""
+""" this setup.py file is build for compilation on macOS with py2app"""
 
 import os
+import getpass
 from setuptools import setup
 from settings import Settings
 
+REMOVE_OLD_BUILD = True  # delete /build and /dist
+
 APP = ['main.py']
+USER_NAME = getpass.getuser()
 
 SOUND_FILES = ["assets/sounds/drop.wav"]
 
@@ -24,9 +22,13 @@
                "assets/images/mutedBell.png"]
 
 OPTIONS = {'argv_emulation': False,
-           'includes': '',
+           'includes': 'numpy, tkinter, PIL, pyaudio, darkdetect',
            'excludes': '',
-           'iconfile': 'assets/images/GuitarTunerDesign.icns',
+           'frameworks': '/Users/{}/miniconda3/lib/libffi.6.dylib,'.format(USER_NAME) +
+                         '/Users/{}/miniconda3/lib/libtk8.6.dylib,'.format(USER_NAME) +
+                         '/Users/{}/miniconda3/lib/libtcl8.6.dylib'.format(USER_NAME),
+           # For whatever reason, py2app didn't include these 3 frameworks automatically. (path can be different)
+           'iconfile': 'assets/images/GuitarTuner_Icon.icns',
            'plist': {
                'CFBundleName': Settings.APP_NAME,
                'CFBundleDisplayName': Settings.APP_NAME,
@@ -39,7 +41,6 @@
                'NSHumanReadableCopyright': u"Copyright © {}, {}, All Rights Reserved".format(Settings.YEAR, Settings.AUTHOR)
            }}
 
-REMOVE_OLD_BUILD = True
 
 if REMOVE_OLD_BUILD is True:
     os.system("rm -r build")