Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest file headings after typing # #8

Closed
borekb opened this issue Aug 9, 2018 · 4 comments
Closed

Suggest file headings after typing # #8

borekb opened this issue Aug 9, 2018 · 4 comments
Assignees

Comments

@borekb
Copy link

borekb commented Aug 9, 2018

@TomasHubelbauer

Due to performance issues on larger repositories (#4, #7), I cannot currently use file suggestions in their full form. However, I think it should be feasible to scope it to current file only, for example, when I type this (| is a cursor):

[link to a section of a file](#|)

and press Ctrl+Space, I would get a list of anchors from the current file. Would make my life a little bit easier :)

@TomasHubelbauer TomasHubelbauer self-assigned this Aug 9, 2018
@TomasHubelbauer
Copy link
Owner

TomasHubelbauer commented Aug 11, 2018

I've cut a new release, 10.0.0, which adds a mode that kicks in after typing ](# and suggests only current file headers.

For $REASONS this was not possible to do completely nicely. Not a problem, I plan on revamping the suggestion logic to support artitrary suggestion triggering points within the MarkDown link instead of just the first character of either the text or the URL, so I bolted a solution on in the meantime which will serve your need and when I get to refactoring, I'll make sure to preserve this new mode.

Please let me know if all is well, I'm closing for now and will reopen in case of problems.

@borekb
Copy link
Author

borekb commented Aug 12, 2018

It works beautifully, thank you!

@TomasHubelbauer
Copy link
Owner

While the initial suggestion list is populated, typing to narrow it down doesn't work as per #11. This problem will be fixed soon and will remain tracked in the related issue #11.

@TomasHubelbauer
Copy link
Owner

This has been fixed together with #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants