Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables not cleaned up if materialized = table and static external location #54

Closed
ojaved-equip opened this issue Jan 3, 2022 · 2 comments · Fixed by #73
Closed

Tables not cleaned up if materialized = table and static external location #54

ojaved-equip opened this issue Jan 3, 2022 · 2 comments · Fixed by #73

Comments

@ojaved-equip
Copy link

Looks like issue was caused by this merge: #43

If we have a static external location and materialized = table (for full overwrite), the prior data in the external location is not cleaned up.
@courentin
Copy link
Contributor

Thank you for this issue, I'm having the same error, I think #49 is fixing this issue

@chronitis chronitis mentioned this issue Jan 25, 2022
Open
@nicholsondarius nicholsondarius mentioned this issue Feb 22, 2022
Merged
nialloriordan pushed a commit to nialloriordan/dbt-athena that referenced this issue Mar 10, 2022
@oriordanniall
resolve Tomme#54
d67d848 
Tables not cleaned up if materialized = table
and static external location
@oriordanniall oriordanniall mentioned this issue Mar 10, 2022
Closed
@nialloriordan
Copy link
Contributor

nialloriordan commented Mar 10, 2022 •
edited
Loading

@courentin @ojaved-equip I have created a new PR #73 that fixes this issue.

Thank you to @datalytics1 for the original PR

@nialloriordan nialloriordan mentioned this issue Mar 10, 2022
Merged
@Tomme Tomme closed this as completed in #73 Jun 6, 2022
Tomme pushed a commit that referenced this issue Jun 6, 2022
@nialloriordan @oriordanniall
resolve #54 (#73)
b641dad 
Tables not cleaned up if materialized = table
and static external location

Co-authored-by: Niall O'Riordan <[email protected]>
nicor88 referenced this issue in dbt-labs/dbt-athena Nov 16, 2022
@nialloriordan @oriordanniall @nicor88
resolve #54 (#73)
2625e67 
Tables not cleaned up if materialized = table
and static external location

Co-authored-by: Niall O'Riordan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@courentin @nialloriordan @ojaved-equip