-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Prettier for this repo #100
Comments
What would be your preferred prettierrc config? And you think that will apply to everyone?
? |
That looks fine to me. I don't have a strong opinion on what the default config should be; it's quite easy to change it if you don't like the default. But I do think that by default, the project should come pre-linted/prettified. |
Another option would be to use the
|
A cool feature of
svelte-ionic-app
is that it can install Prettier for you.However, the project files aren't currently linted with Prettier; after creating a new project, Prettier changes 7 files.
Steps to reproduce
npm create ionic-svelte-app@latest
cd myNewApp
npm run format
Prettier reformats the following files:
At a minimum, I think these should be cleaned up in the repo so that when you create a new project with Prettier, the files are already "prettified."
But it might be good to go ahead and reformat the whole repo with Prettier. I did this locally and it's a huge number of changes, but as far as I know, Prettier shouldn't break anything, so it's something to consider.
The text was updated successfully, but these errors were encountered: