-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating an app with: npm create ionic-svelte-app@latest
no longer includes any pwa code? The src/lib
folder is now empty when creating a new project.
#84
Comments
Hi Yes I did not feel that should be part of what the package should distribute also because the vite pwa api can change. Next the vite pwa docs have better documented info on service workers and so on. Happy to hear other thoughts... |
Can you at least just link to the docs on how to set up PWA in a project? Make it part of the setup flow at least. |
You mean like adding a link in the closing comments? Link to Vite PWA? https://github.com/vite-pwa/sveltekit |
Yeah, I'd copy over the steps needed to set up the PWA and include it in your readme, and provide a link as well. :) |
Feel like doing a PR on the README? |
I created a branch and tried to push it, but I don't have access:
|
You need to fork it and then create a change and then do a PR |
Ok, I'm now revising this and when I create a new app with Does anyone have some working pwa code using the latest SveltKit setup here (preferably that allows apps to work offline and auto-updates like the app used to)? |
I tried to build and deploy the demo app in the source tree here, and it installs a service worker, but it doesn't work offline (and I'm not sure if it auto-updates either.) |
I was able to get things working by studying this project: |
Creating an app with:
npm create ionic-svelte-app@latest
no longer includes any pwa code? Thesrc/lib
folder is now empty when creating a new project.The lib folders were removed by this commit on Feb 15:
4e6e7fe
The text was updated successfully, but these errors were encountered: