-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QLineEdit support to UISliderWidget #168
base: main
Are you sure you want to change the base?
Conversation
Updated PR title to reflect changes to the design of the UISliderWidget class. Following discussions with @paskino and @DanicaSTFC, it was agreed that instead of a QDoubleSpinBox the UISliderWidget class would make better use of a QLineEdit, removing restrictions on the decimal values users can input. |
update docstrings
to test_UISliderWidget class
Need to clarify whether an empty |
recipe/eqt_env.yml
Outdated
@@ -6,3 +6,4 @@ dependencies: | |||
- pip | |||
- qtpy | |||
- qdarkstyle | |||
- parameterized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this or is it only optional for the developer environment? Isn't it enough to add it to the pyproject? I am not sure
@@ -0,0 +1,295 @@ | |||
import unittest | |||
|
|||
from parameterized import parameterized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to add this in the developer requirements, and conda actions
Closes #125 #60
The current UISliderWidget is limited due to the following factors:
This pull request originally removed the QLabel parameter in favour of a QDoubleSpinBox parameter. It was decided that to provide the best user experience and enable flexibility to modify the widget in the future, more changes would be required:
test_UISliderWidget.py
/examples/
folder have been updated to accommodate the updated UISliderWidgetPLEASE NOTE: By default the
QSlider.value()
method only returns integer values - even if the value of the QLineEdit is a float/double, this value is automatically converted to an integer when the QSlider value is updated. Additional methods have been implemented to convert the QSlider value into a scaled QLineEdit value, and vice versa. This means the QSlider can now accurately represent float/double values.Current Tasks:
Overload the init, one with the DSpinBox and one without