Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality #610

Open
TooAngel opened this issue Oct 1, 2020 · 2 comments
Open

Code quality #610

TooAngel opened this issue Oct 1, 2020 · 2 comments

Comments

@TooAngel
Copy link
Owner

TooAngel commented Oct 1, 2020

Working on it for some time, it still needs to be better.
Code climate is a got point to have a look.
Basically it is reducing complexity and length of functions and splitting up large files into smaller units.

@iyosayi
Copy link

iyosayi commented Oct 1, 2020

Hello, @TooAngel could you please explain more? I would love to take this issue.

@TooAngel
Copy link
Owner Author

TooAngel commented Oct 1, 2020

Not sure if you know screeps (https://screeps.com/). It is a massive multiple player strategy game with an in game editor.
I released my code as bot (which everyone can use on their private servers) as well as a code base for others.
A lot of code is written in the in game editor while playing the game, so written fast not optimized on quality.

I added codeclimate (https://codeclimate.com/) which showed that there is a lot of complexity. You can also run eslint -c .eslintrc-codeclimate src/. I think extracting certain functionality into other methods / splitting up files can solve a lot of issues.

I also think there is also room for improvement in javascript/nodejs knowledge, it was my first bigger project getting into javascript.

Does that help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants