-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Budgetholder is queried when none is provided in account object #14
Comments
Unfortunately, this doesn't work as other features depend on an empty or null department. |
@Rick-Jongbloed , a check if the property exists isn't that complex either right?
However, the main issue is for budgetHolder as this is not a required field, whereas departmet is in that case. |
This is fixed in the new PSv2. Linked to new branch/pr |
When we don't use a field, we don't provide it in the mapping (account) object.
However, if I outcomment (or remove) the field budgetHolder, like so:
The function Get-TopdeskBudgetHolder to query the Topdesk budgetholder ID is still performed and returns the following error:
Requested to lookup budgetholder, but budgetholder.lookupValue is missing. This is a scripting issue.
IMO this should not be the case. We should only query and use the provided fields of the mapping (account) object.
This can be easily solved by changing this:
To this:
The example given is for budgetholder, but this should be for every field (that isn't required).
The text was updated successfully, but these errors were encountered: