Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In testing actions install without CUDA. #47

Closed
PierreQuinton opened this issue Jun 22, 2024 · 1 comment
Closed

In testing actions install without CUDA. #47

PierreQuinton opened this issue Jun 22, 2024 · 1 comment
Labels

Comments

@PierreQuinton
Copy link
Contributor

No description provided.

@PierreQuinton PierreQuinton changed the title In CI install without CUDA. In testing actions install without CUDA. Jun 22, 2024
@ValerianRey ValerianRey added the ci label Jun 23, 2024
@ValerianRey ValerianRey modified the milestone: v0.2.0 Release Jul 9, 2024
@ValerianRey
Copy link
Contributor

I think there would be two ways of doing this, but none would work satisfyingly:

  • We could add "+cpu" in the version of torch, and try to have an optional dependency for torch with this, and another one, used by default when the cpu version is not used, without this. However, I have no idea how to have a default optional dependency, or how to make the optional dependency override a core dependency. Also, there would be no way to indicate "torch>=x.y.z+cpu", we would have to have version equality "torch==x.y.z+cpu" which we do not want.
  • We could use another index to download torch from, as suggested in this issue's comment. However, this would always make pdm download torch from the cpu-specific index, meaning there would be no way to install the project with cuda when using pdm, as far as I know. Also, it actually does not seem to work with the pdm action: https://github.com/TorchJD/torchjd/actions/runs/10547965708/job/29221298322 installs cuda torch...

Since this is not so critical and way to complex to solve, I'll close this issue.

@ValerianRey ValerianRey closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants