Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora Package #53

Open
khoitd1997 opened this issue Apr 12, 2019 · 3 comments
Open

Fedora Package #53

khoitd1997 opened this issue Apr 12, 2019 · 3 comments

Comments

@khoitd1997
Copy link
Contributor

Hi, my name is Khoi Trinh, I recently started using TOML with C++ and find your library really helpful, as such, I want to help make it a Fedora package so that other users can simply do #include <toml11/toml.hpp> after a quick installation using dnf. Is there any potential issues or major features that toml11 is expecting? Thank you for your work in this library.

@ToruNiina
Copy link
Owner

I don't know how to upload a package to Fedora, so I don't have any idea about potential issues around that, sorry.

If you mean potential issues or major features in the more general sense, it is possible there are more bugs to be fixed (recently I found and fixed a bug in ""_toml literal). Also, some other features such as preserving comments can be introduced, and error messages can be improved.

@khoitd1997
Copy link
Contributor Author

Hi, I'm asking about the general sense as I just want to know if there is gonna be major changes happening soon so that I can wait before preparing to package the applications. This is a header library and Fedora has a pretty well-defined procedure for packaging them so it shouldn't be a problem on the packaging side. Thank you for answering my question, please let me know if you can think of any big issues or improvements, otw, I will package this library and it will hopefully make it to a standard Fedora release in the future.

@khoitd1997
Copy link
Contributor Author

I just want to keep you posted on this process, I have made the necessary spec files for toml11, a copr build is available, the only potential issue is #57 since unit tests are run as part of the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants