Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @vue/composition-api from peerDependencies #17

Open
IlyaSemenov opened this issue Oct 16, 2024 · 1 comment
Open

Remove @vue/composition-api from peerDependencies #17

IlyaSemenov opened this issue Oct 16, 2024 · 1 comment

Comments

@IlyaSemenov
Copy link

IlyaSemenov commented Oct 16, 2024

@townsquarelabs/ui-vue lists @vue/composition-api as a peer dependency:

"@vue/composition-api": "^1.0.0-rc.1",

There is no point in doing so. The package never imports or uses @vue/composition-api in any other way. As such, @vue/composition-api should not be listed as a dependency.

Having it pulls unnecessary libraries in Vue 3 projects and pollutes output with warnings:

 WARN  Issues with peer dependencies found
.
└─┬ @vue/composition-api 1.7.2
  └── ✕ unmet peer vue@">= 2.5 < 2.7": found 3.4.37
@kkkkh
Copy link

kkkkh commented Nov 10, 2024

@townsquarelabs/ui-vue lists @vue/composition-api as a peer dependency:

"@vue/composition-api": "^1.0.0-rc.1",

There is no point in doing so. The package never imports or uses @vue/composition-api in any other way. As such, @vue/composition-api should not be listed as a dependency.

Having it pulls unnecessary libraries in Vue 3 projects and pollutes output with warnings:

 WARN  Issues with peer dependencies found
.
└─┬ @vue/composition-api 1.7.2
  └── ✕ unmet peer vue@">= 2.5 < 2.7": found 3.4.37

@IlyaSemenov
Yes, you are right. The package after building does not need "peerDependencies": {
"@vue/composition-api": "^1.0.0-rc.1",}. The reason why it exists in package.json is because this dependency is needed during development. Later, we will separate the build and dev of the code. The package after building will remove unnecessary dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants