Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Experimental) Add DecentHolograms Support #386

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheFlagCourier
Copy link
Member

@TheFlagCourier TheFlagCourier commented Nov 11, 2024

🙃

Brief Description:

An attempt to add support for DescentHolograms, supplementing the already-established HolographicDisplays(EOL) support.

Right now, I have it hooked up as a fall-back/alternative implementation. CellUnderAtttack.drawHologram() will prefer HolographicDisplays over DescentHolograms.


Changes:

  • Update NOTICE file
  • Update POM (dependency plumbing and minor fixes.)
  • Add a check to FlagWarConfig
  • CellUnderAttack:
    • Split out drawHologram into drawHolographicDisplay and drawDescentHologram
    • Add setTimerLineDHAPI() (and related field)
    • Update updateHologram() and destroyHologram()
  • Add DescentHolograms as a soft-depend to plugin.yml

Relevant FlagWar Issue tickets:

closes #313



By making this pull request, I represent that I have read and agree to release my own changes that I
have submitted under the terms of the accompanying license (Apache-2.0). I guarantee that these
changes are mine and are not encumbered by any other license or restriction to the best of my
knowledge.

@TheFlagCourier TheFlagCourier requested a review from LlmDl November 11, 2024 03:17
@TheFlagCourier TheFlagCourier added enhancement New feature or request dependencies Pull requests that update a dependency file awaiting-feedback Marks tickets and pulls for requesting additional response from their authors. labels Nov 11, 2024
@LlmDl LlmDl changed the title (Experimental) Add DescentHolograms Support (Experimental) Add DecentHolograms Support Nov 11, 2024
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aside from the typos that's probably going to keep it from working.

@TheFlagCourier
Copy link
Member Author

D'oh! Thanks for pointing that out.

Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, once we hear back that it does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-feedback Marks tickets and pulls for requesting additional response from their authors. dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change from HolographicDisplays for holograms to another plugin
2 participants