Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towny layer is lost when reloading Pl3xMap #60

Open
Folas1337 opened this issue Jul 7, 2024 · 2 comments
Open

Towny layer is lost when reloading Pl3xMap #60

Folas1337 opened this issue Jul 7, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@Folas1337
Copy link

Describe the Bug

When you're running MapTowny alongside Pl3xMap and use '/map reload', the layer for MapTowny is lost and can only be retrieved by restarting the server.

Expected Behavior

The layer should persist even after a reload.

Plugin Version

MapTowny version 3.0.0-ALPHA-2

Towny Version

Towny version 0.100.3.3

Pl3xMap Version

Pl3xMap version 1.21-501

Server Software Version

This server is running Paper version 1.21-46-master@2fa5e0e (2024-07-06T21:32:48Z) (Implementing API version 1.21-R0.1-SNAPSHOT)

Additional Comments

I asked on the Pl3xMap Discord whose fault this might be and here are some comments:

Haven wrote:

maptowny is probably adding them with the api instead of a config file, that's my assumption

BillyGalbreath wrote:

that would be MapTowny's fault. Pl3xMap throws out some events to let other plugins/addons know whats up. For the addon to re-add their marker layer they need to listen to the WorldLoadedEvent

@Folas1337 Folas1337 added the bug Something isn't working label Jul 7, 2024
@silverwolfg11
Copy link
Collaborator

Thanks for reporting this! I wasn't aware that the layers didn't persist on Pl3xMap reload, so I'll check out that API.

@Folas1337
Copy link
Author

Seems that's working beautifully on the latest alpha 3.0.0-ALPHA-3 👍

From my side this ticket can be closed but if you want to keep it open until you actually release 3.0.0 that's fine, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants