Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oa-verify polyfills #7

Open
simboonlong opened this issue Mar 22, 2023 · 3 comments
Open

oa-verify polyfills #7

simboonlong opened this issue Mar 22, 2023 · 3 comments

Comments

@simboonlong
Copy link
Contributor

simboonlong commented Mar 22, 2023 •
edited
Loading

oa-verify open-attestation lib seems to be causing integration problems, which can be overcome by reintroducing back some nodejs polyfills. same issue as TradeTrust/document-creator-website#244
@superical
Copy link

Ehh.... I just tried importing oa-verify lib recently in react, didn't get any errors and I also didn't add any polyfills. Just curious, what problems would it cause when importing oa-verify lib? Is the problem only specifically with create-react-app?

@simboonlong
Copy link
Contributor Author

simboonlong commented Mar 24, 2023 •
edited
Loading

this only happens with CRA v5 onwards, whereby react-scripts had a bump to webpack5, specifically:

No node js builtin shims (breaking as in Webpack 5)

there is an attempted fix as of now. haven looked into it though

@superical
Copy link

Ahh I see! Thanks!

@john-dot-oa john-dot-oa mentioned this issue Jan 1, 2024
Open
This was referenced Feb 20, 2024
Open
Open
@john-dot-oa john-dot-oa mentioned this issue Mar 15, 2024
Open
@john-dot-oa john-dot-oa mentioned this issue Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@superical @simboonlong