Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implementation of moment.js #889

Open
renato-b opened this issue Nov 5, 2019 · 0 comments
Open

Remove implementation of moment.js #889

renato-b opened this issue Nov 5, 2019 · 0 comments

Comments

@renato-b
Copy link

renato-b commented Nov 5, 2019

The UI library comes with an embedded implementation of moment.js (tradeshift-ui/src/third-party/moment-with-locale.js) which is available at ts.ui.moment.
This is not really optimal as the moment library can be included independently in the package.json file if needed. Moreover if independently used it can be upgraded easily to the latest version.

Hint: Jacob and Nima have developed a tool to search for patters in our GIT repository; it can be used to see if any front-end app refers to the string ts.ui.moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants