Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support More Language For Item Name #161

Open
2 of 3 tasks
Hatsuharu33227 opened this issue Nov 7, 2023 · 2 comments
Open
2 of 3 tasks

Support More Language For Item Name #161

Hatsuharu33227 opened this issue Nov 7, 2023 · 2 comments
Assignees

Comments

@Hatsuharu33227
Copy link

Hatsuharu33227 commented Nov 7, 2023

Is your feature request related to a problem?

Since my players are not native English speakers, some of them may not understand the item names in English.

Describe the solution you'd like.

Add an option in the config for ‘Item-Lang’ to display item names in different languages. These can be retrieved from Minecraft’s JSON. For example, you could use ‘fr-FR’ for French, ‘ja-JP’ for Japanese, ‘ko-KR’ for Korean, and ‘zh-TW’ for Traditional Chinese.

Describe alternatives you've considered.

These can be retrieved from Minecraft’s JSON.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported TradeShop build.
  • I have asked the Developers and they have confirmed that it is not already in development.

Other

No response

@SparklingComet
Copy link
Member

SparklingComet commented Nov 7, 2023

What do you mean by item names? What items is the plugin naming?

@KillerOfPie
Copy link
Collaborator

We already "support" all language we just haven't had anyone make translated lang files.

As far as the item names go, those are pulled from minecraft and should be using the localized name already. If they are seeing english then either the server or their client are not set to the correct language.

Also please make sure to search through the existing issues(including closed ones) before making Feature requests.

#122 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants