Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6.2 - Fix JsonShopConfiguration saves #157

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

2.6.2 - Fix JsonShopConfiguration saves #157

wants to merge 42 commits into from

Conversation

SparklingComet
Copy link
Member

Pull Request Etiquette

There are several guidelines you should follow in order for your Pull Request to be merged.
Replace [ ] with [x] to cross the checkbox.

It is sometimes better to include more related changes in a single commit.
If you find yourself having an overwhelming amount of commits, you
can rebase your branch.

Changes

Fix for bug reported on discord about shop deletion not being saved/reflected in save files. Also introduces a thread (task) pool system for better performance. The previous async saving implementation relying on HashMaps as semaphores/locks was only a band-aid fix.

I have done some basic testing with 1-2 threads, more stress-testing (more queued save jobs, more threads) would be helpful.

- Added save validation that checks for excess '{' or '}' and attempts to re-save with them removed
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§b§2§3§6§1`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§b§2§c§6§1`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§f§2§c§6§1`
KillerOfPie and others added 20 commits November 15, 2023 21:27
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§2§c§6§1`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§2§c§6§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§1§c§6§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§1§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§1§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§1§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§7§6§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§3§6§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§3§c§2§f§6`
- There is a good chance this will not properly load existing shop data. To prevent this from affecting servers that haven't confirmed, the Message Prefix setting in the config will need to START with `§a§3§c§2§f§6`
- fox for findchest npe
- fix for concurrentmod exception
- Fix for missing config #
- Removed FileCache from JsonConfiguration
@hmlendea
Copy link

hmlendea commented Jul 4, 2024

Will this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants