Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 released on PyPI differs from release 1.0.0 on Github #59

Open
eirikff opened this issue Aug 16, 2024 · 0 comments
Open

Comments

@eirikff
Copy link

eirikff commented Aug 16, 2024

Describe the bug
The version I get when I install from PyPI by running pip install django-admin-confirm differs from the release here on Github. The major difference I've notices is that the version on PyPI doesn't have the updated __init__.py, so to import the decorator confirm_action we need to write from admin_confirm.admin import confirm_action instead of from admin_confirm import confirm_action as the example in the readme.

To Reproduce
Steps to reproduce the behavior:

  1. Create a fresh virtual environment.
  2. Install django-admin-confirm with pip install django-admin-confirm.
  3. Create a django application with an admin module, and write from admin_confirm import confirm_action at the top.

Expected behavior
The confirm_action decorator to be imported without having to specify the extra .admin in the module name.

Versions (please complete the following information):

  • Python 3.12.4
  • Pip 24.2
  • django-admin-confirm 1.0.0 (the one downloaded from PyPI)
  • Django 5.0.7 (shouldn't matter which Django version I'm using as the downloaded files are different)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant