You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some functions in TransformerLens where position and keyed arguments are allowed for the purpose of passing down to other functions. model_args should be removed in favor of model_kwargs.
Motivation
Having the two together is only really adding some confusion. On top of that, we cannot change the order of params without causing subtle issues that many people may not even notice.
Pitch
We can keep model_kwargs, since that one is going to give us a much better compatibility, and it will help make the code more verbose.
Alternatives
Additional context
Checklist
I have checked that there is no similar issue in the repo (required)
The text was updated successfully, but these errors were encountered:
Proposal
There are some functions in TransformerLens where position and keyed arguments are allowed for the purpose of passing down to other functions.
model_args
should be removed in favor ofmodel_kwargs
.Motivation
Having the two together is only really adding some confusion. On top of that, we cannot change the order of params without causing subtle issues that many people may not even notice.
Pitch
We can keep
model_kwargs
, since that one is going to give us a much better compatibility, and it will help make the code more verbose.Alternatives
Additional context
Checklist
The text was updated successfully, but these errors were encountered: