Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Remove instances where model_args and model_kwargs are provided #798

Open
1 task done
bryce13950 opened this issue Nov 26, 2024 · 0 comments
Open
1 task done
Labels
breaking-change complexity-simple Simple issues, which may be good for beginners

Comments

@bryce13950
Copy link
Collaborator

Proposal

There are some functions in TransformerLens where position and keyed arguments are allowed for the purpose of passing down to other functions. model_args should be removed in favor of model_kwargs.

Motivation

Having the two together is only really adding some confusion. On top of that, we cannot change the order of params without causing subtle issues that many people may not even notice.

Pitch

We can keep model_kwargs, since that one is going to give us a much better compatibility, and it will help make the code more verbose.

Alternatives

Additional context

Checklist

  • I have checked that there is no similar issue in the repo (required)
@bryce13950 bryce13950 added breaking-change complexity-simple Simple issues, which may be good for beginners labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change complexity-simple Simple issues, which may be good for beginners
Projects
None yet
Development

No branches or pull requests

1 participant