Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get fill_prob_matrix tests passing #4

Open
glesica opened this issue Jan 9, 2020 · 1 comment
Open

Get fill_prob_matrix tests passing #4

glesica opened this issue Jan 9, 2020 · 1 comment
Assignees
Labels
bug Something isn't working testing Work related to validation and verification
Milestone

Comments

@glesica
Copy link
Collaborator

glesica commented Jan 9, 2020

Right now we're attempting to verify our results against those from the Perl script. There are two outstanding challenges, however:

  1. The numbers are "off", but this may be explained by the fact that the Perl script was using a 0.0 change probability. We may want to fix the Perl script, re-run, and then check the tests with the new results.
  2. The Python script reports row / column results that are omitted from the Perl output. We should decide how we want this to work and harmonize the two implementations. We probably want the Python script to work like the Perl script.
@glesica glesica added bug Something isn't working testing Work related to validation and verification labels Jan 9, 2020
@glesica glesica added this to the 1.0 Release milestone Jan 9, 2020
@glesica
Copy link
Collaborator Author

glesica commented Dec 9, 2020

The description above is no longer accurate, but we still probably need a couple tests for this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Work related to validation and verification
Projects
None yet
Development

No branches or pull requests

2 participants