Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: The setting parameter disableRender of TresCanvas is ineffective when renderMode is set to always. #766

Closed
5 tasks done
hawk86104 opened this issue Jul 11, 2024 · 4 comments · Fixed by #838
Closed
5 tasks done
Labels
bug Something isn't working

Comments

@hawk86104
Copy link
Contributor

Describe the bug

As mentioned in the title, in version v4.1.0

Reproduction

https://stackblitz.com/edit/tresjs-minimal-reproduction-7tdaba?file=src%2FApp.vue

Steps to reproduce

No response

System Info

No response

Used Package Manager

npm

Code of Conduct

@hawk86104
Copy link
Contributor Author

hawk86104 commented Jul 11, 2024

v4.10 lib file:src/utils/index.ts
setPrimitiveObject

// NOTE: copy added/attached Vue children
// We need to insert objects into newObject later.
// In the meantime, remove(primitive) will alter
// the array, so make a copy.

I believe there is an issue with this. In the following code, meshOB cannot be operated on.

<primitive :object="gridHelp" />
gridHelp.parent 
gridHelp.visible = false

@alvarosabu
Copy link
Member

Actually that prop disableRender should be deprecated

@alvarosabu alvarosabu self-assigned this Aug 21, 2024
@alvarosabu alvarosabu added the pending-triage Ticket is pending to be prioritised label Aug 21, 2024
@alvarosabu alvarosabu removed their assignment Aug 21, 2024
@Neosoulink
Copy link

@alvarosabu I can work on this if no one already working on this one

@Tinoooo Tinoooo added bug Something isn't working and removed pending-triage Ticket is pending to be prioritised labels Sep 22, 2024
@Tinoooo Tinoooo linked a pull request Sep 22, 2024 that will close this issue
@Tinoooo
Copy link
Contributor

Tinoooo commented Sep 22, 2024

Deprecating the prop is not possible anymore as it already has no effect. I removed it in #838.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants