From 1adfda0fb083157aebc4737ff7f97ae8b3581789 Mon Sep 17 00:00:00 2001 From: "Roscoe A. Bartlett" Date: Mon, 5 Dec 2022 11:01:17 -0500 Subject: [PATCH 1/5] Update tribits_testing.yml --- .github/workflows/tribits_testing.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/tribits_testing.yml b/.github/workflows/tribits_testing.yml index f1eb10b7e..495305608 100644 --- a/.github/workflows/tribits_testing.yml +++ b/.github/workflows/tribits_testing.yml @@ -19,11 +19,11 @@ jobs: fail-fast: false # Allow each job to run to completion even if other jobs fail first matrix: config: - - { os: ubuntu-latest, cmake: "3.17.5", generator: "makefiles", python: "2.7", cc: gcc-8, cxx: g++-8, fc: gfortran-8 } - - { os: ubuntu-latest, cmake: "3.17.5", generator: "makefiles", python: "3.8", cc: gcc-10, cxx: g++-10, fc: gfortran-10 } - - { os: ubuntu-latest, cmake: "3.17.5", generator: "makefiles", python: "3.8", cc: gcc-11, cxx: g++-11 } - - { os: ubuntu-latest, cmake: "3.21.2", generator: "makefiles", python: "3.8", cc: gcc-9, cxx: g++-9, fc: gfortran-9, no_have_ninja: no-ninja } - - { os: ubuntu-latest, cmake: "3.23.1", generator: "makefiles", python: "3.8", cc: gcc-9, cxx: g++-9, fc: gfortran-9 } + - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "2.7", cc: gcc-9, cxx: g++-9, fc: gfortran-9 } + - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-10, cxx: g++-10, fc: gfortran-10 } + - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-11, cxx: g++-11 } + - { os: ubuntu-latest, cmake: "3.23.1", generator: "makefiles", python: "3.8", cc: gcc-9, cxx: g++-9, fc: gfortran-9, no_have_ninja: no-ninja } + - { os: ubuntu-latest, cmake: "3.25.1.1", generator: "makefiles", python: "3.8", cc: gcc-12, cxx: g++-12, fc: gfortran-12 } runs-on: ${{ matrix.config.os }} From 5e2d4f023fa7d65b5f4c6711e43ed0d27a536bb1 Mon Sep 17 00:00:00 2001 From: "Roscoe A. Bartlett" Date: Mon, 5 Dec 2022 11:05:11 -0500 Subject: [PATCH 2/5] Fix typo Fix type in CMake 3.25.1 --- .github/workflows/tribits_testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tribits_testing.yml b/.github/workflows/tribits_testing.yml index 495305608..dea2542d4 100644 --- a/.github/workflows/tribits_testing.yml +++ b/.github/workflows/tribits_testing.yml @@ -23,7 +23,7 @@ jobs: - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-10, cxx: g++-10, fc: gfortran-10 } - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-11, cxx: g++-11 } - { os: ubuntu-latest, cmake: "3.23.1", generator: "makefiles", python: "3.8", cc: gcc-9, cxx: g++-9, fc: gfortran-9, no_have_ninja: no-ninja } - - { os: ubuntu-latest, cmake: "3.25.1.1", generator: "makefiles", python: "3.8", cc: gcc-12, cxx: g++-12, fc: gfortran-12 } + - { os: ubuntu-latest, cmake: "3.25.1", generator: "makefiles", python: "3.8", cc: gcc-12, cxx: g++-12, fc: gfortran-12 } runs-on: ${{ matrix.config.os }} From 7dc55d145ca1dedca891519006f2be17f9a6c49c Mon Sep 17 00:00:00 2001 From: "Roscoe A. Bartlett" Date: Mon, 5 Dec 2022 11:11:48 -0500 Subject: [PATCH 3/5] Remove Python 2.7 build It seems that Python 2.7 is no longer supported for GitHub Actions testing. Given that official support for Python 2.x was dropped on 1/1/2020, it seems like it might be reasonable to drop testing for it nearly 3 years later. --- .github/workflows/tribits_testing.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tribits_testing.yml b/.github/workflows/tribits_testing.yml index dea2542d4..da514374d 100644 --- a/.github/workflows/tribits_testing.yml +++ b/.github/workflows/tribits_testing.yml @@ -19,7 +19,6 @@ jobs: fail-fast: false # Allow each job to run to completion even if other jobs fail first matrix: config: - - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "2.7", cc: gcc-9, cxx: g++-9, fc: gfortran-9 } - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-10, cxx: g++-10, fc: gfortran-10 } - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-11, cxx: g++-11 } - { os: ubuntu-latest, cmake: "3.23.1", generator: "makefiles", python: "3.8", cc: gcc-9, cxx: g++-9, fc: gfortran-9, no_have_ninja: no-ninja } From a39f1a367d9296c9f8ff01079a486fa253cec36d Mon Sep 17 00:00:00 2001 From: "Roscoe A. Bartlett" Date: Mon, 5 Dec 2022 12:14:43 -0500 Subject: [PATCH 4/5] Adjust builds to vary CMake and GCC versions Need to see if coverage segfaults are due to CMake 3.25.1 or gcc-12. --- .github/workflows/tribits_testing.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tribits_testing.yml b/.github/workflows/tribits_testing.yml index da514374d..12720fe94 100644 --- a/.github/workflows/tribits_testing.yml +++ b/.github/workflows/tribits_testing.yml @@ -19,9 +19,9 @@ jobs: fail-fast: false # Allow each job to run to completion even if other jobs fail first matrix: config: - - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-10, cxx: g++-10, fc: gfortran-10 } + - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-9, cxx: g++-9, fc: gfortran-9 } - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-11, cxx: g++-11 } - - { os: ubuntu-latest, cmake: "3.23.1", generator: "makefiles", python: "3.8", cc: gcc-9, cxx: g++-9, fc: gfortran-9, no_have_ninja: no-ninja } + - { os: ubuntu-latest, cmake: "3.23.1", generator: "makefiles", python: "3.8", cc: gcc-12, cxx: g++-12, fc: gfortran-12, no_have_ninja: no-ninja } - { os: ubuntu-latest, cmake: "3.25.1", generator: "makefiles", python: "3.8", cc: gcc-12, cxx: g++-12, fc: gfortran-12 } runs-on: ${{ matrix.config.os }} From b4f1e0174c5412b7b2a3d65788ba3bc15bc9a7bb Mon Sep 17 00:00:00 2001 From: "Roscoe A. Bartlett" Date: Mon, 5 Dec 2022 14:08:09 -0500 Subject: [PATCH 5/5] Remove usage of gcc-12 The segfaults in the coverage testing is caused by gcc-12, not CMake 3.25.1. Restricting usage to GCC 9 through 11 (since GCC 8 and below is no longer supported). --- .github/workflows/tribits_testing.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tribits_testing.yml b/.github/workflows/tribits_testing.yml index 12720fe94..8dcc11641 100644 --- a/.github/workflows/tribits_testing.yml +++ b/.github/workflows/tribits_testing.yml @@ -20,9 +20,9 @@ jobs: matrix: config: - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-9, cxx: g++-9, fc: gfortran-9 } - - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-11, cxx: g++-11 } - - { os: ubuntu-latest, cmake: "3.23.1", generator: "makefiles", python: "3.8", cc: gcc-12, cxx: g++-12, fc: gfortran-12, no_have_ninja: no-ninja } - - { os: ubuntu-latest, cmake: "3.25.1", generator: "makefiles", python: "3.8", cc: gcc-12, cxx: g++-12, fc: gfortran-12 } + - { os: ubuntu-latest, cmake: "3.22.4", generator: "makefiles", python: "3.8", cc: gcc-10, cxx: g++-10 } + - { os: ubuntu-latest, cmake: "3.23.1", generator: "makefiles", python: "3.8", cc: gcc-11, cxx: g++-11, fc: gfortran-11, no_have_ninja: no-ninja } + - { os: ubuntu-latest, cmake: "3.25.1", generator: "makefiles", python: "3.8", cc: gcc-11, cxx: g++-11, fc: gfortran-11 } runs-on: ${{ matrix.config.os }}