Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for TriBITS package dependencies depending on package test group #568

Open
bartlettroscoe opened this issue Mar 2, 2023 · 0 comments

Comments

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Mar 2, 2023

Description

Currently, it seems that TriBITS does not check and error out if there are incorrect required package dependencies depending the package test group. For example, an required upstream package can not have a a lower testing group than its downstream packages. For example, an ST package can't have a required dependency on an upstream EX package. Likewise, a PT package can't have a required upstream dependency on an ST or an EX package.

For example, in Trilinos PR #11599, anPT package STKMiddle_mesh declared a required dependency on the EX TPL CDT which resulted in the automatic enable of CDT when the auto-enable of STKMiddle_mesh in PT testing (see trilinos/Trilinos#11599 (comment)). This resulted in a configure error because the location of the EX TPL is not given in those configurations. This illogical dependency should have been detected by TriBITS and errored out.

@bartlettroscoe bartlettroscoe changed the title Add asserts for TriBITS package dependencies depending on testing group Add checks for TriBITS package dependencies depending on package test group Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

No branches or pull requests

1 participant