You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, it seems that TriBITS does not check and error out if there are incorrect required package dependencies depending the package test group. For example, an required upstream package can not have a a lower testing group than its downstream packages. For example, an ST package can't have a required dependency on an upstream EX package. Likewise, a PT package can't have a required upstream dependency on an ST or an EX package.
For example, in Trilinos PR #11599, anPT package STKMiddle_mesh declared a required dependency on the EX TPL CDT which resulted in the automatic enable of CDT when the auto-enable of STKMiddle_mesh in PT testing (see trilinos/Trilinos#11599 (comment)). This resulted in a configure error because the location of the EX TPL is not given in those configurations. This illogical dependency should have been detected by TriBITS and errored out.
The text was updated successfully, but these errors were encountered:
bartlettroscoe
changed the title
Add asserts for TriBITS package dependencies depending on testing group
Add checks for TriBITS package dependencies depending on package test group
Mar 2, 2023
Description
Currently, it seems that TriBITS does not check and error out if there are incorrect required package dependencies depending the package test group. For example, an required upstream package can not have a a lower testing group than its downstream packages. For example, an
ST
package can't have a required dependency on an upstreamEX
package. Likewise, aPT
package can't have a required upstream dependency on anST
or anEX
package.For example, in Trilinos PR #11599, an
PT
packageSTKMiddle_mesh
declared a required dependency on theEX
TPLCDT
which resulted in the automatic enable ofCDT
when the auto-enable ofSTKMiddle_mesh
in PT testing (see trilinos/Trilinos#11599 (comment)). This resulted in a configure error because the location of theEX
TPL is not given in those configurations. This illogical dependency should have been detected by TriBITS and errored out.The text was updated successfully, but these errors were encountered: