Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prepare for next release] Reimplement core shape code #126

Open
9 of 13 tasks
darkevilmac opened this issue Jul 9, 2023 · 0 comments
Open
9 of 13 tasks

[Prepare for next release] Reimplement core shape code #126

darkevilmac opened this issue Jul 9, 2023 · 0 comments
Assignees

Comments

@darkevilmac
Copy link
Contributor

darkevilmac commented Jul 9, 2023

Currently shapes are not implemented or working in any form, this ticket is meant to track the implementation of common shapes with simple rotation logic. More advanced shapes like windows need their own tickets.

  • Reimplement EnumShape.
    • No more special cases for placement offsets, these should be part of the spec assuming they're needed.
    • Instead of having a monolithic class for all "ShapeBehaviour" we should separate this logic to avoid duplication.
      • ShapeOrientation
      • ShapePlacementLogic
      • ShapeOrientationResolver
  • The type of shape should be part of the block, not a state property.
    • Properties themselves should be per-shape, derived from placement logic. No more one-size-fits-all approach.
      • ShapeFacingProperty
      • ShapeSpinProperty
      • ShapeAxisProperty
  • Display logic (Render/Bounding)
    • OBJSON is on client and server, we can extract this data on both sides - being mindful not to import any client only classes on the server.

Please note that all release preparation tickets are locked to contributors, these aren't for feature suggestions they are simply for tracking progress

@TridentMC TridentMC locked and limited conversation to collaborators Jul 9, 2023
@darkevilmac darkevilmac self-assigned this May 26, 2024
@darkevilmac darkevilmac changed the title [Prepare for next release] Reimplement shapes [Prepare for next release] Reimplement core shape code May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant