Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more packets #59

Open
caojohnny opened this issue Jan 30, 2017 · 3 comments
Open

Implement more packets #59

caojohnny opened this issue Jan 30, 2017 · 3 comments
Labels
enhancement
Milestone
0.6-alpha

Comments

@caojohnny
Copy link
Member

As we continue development, this is just a landmark issue for implementing more of the packets in the protocol.
@caojohnny caojohnny modified the milestone: 0.5-alpha Jan 30, 2017
@caojohnny
Copy link
Member Author

Should packets be implemented partially in their respective classes or should packets that do not have a proper API developed be handled by a dummy which reads all the data and returns?

@Vilsol
Copy link
Member

Vilsol commented Jul 28, 2017

I think we should implement a dummy and make it ErrorLog that a packet with "this" hex ID isn't registered

@nickrobson
Copy link
Contributor

We could even go one step further and (if the server is in DEBUG mode) message the user that they sent a packet with its ID.

It would be helpful for during the protocol development phase.

@caojohnny caojohnny modified the milestones: 0.6-alpha, 0.5-alpha Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.6-alpha
Development

No branches or pull requests
3 participants
@Vilsol @caojohnny @nickrobson