Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test(#222) : oauth controller #225

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Test(#222) : oauth controller #225

merged 7 commits into from
Oct 18, 2024

Conversation

Astin01
Copy link
Contributor

@Astin01 Astin01 commented Oct 6, 2024 •
edited
Loading

๐Ÿ“์ž‘์—… ๋‚ด์šฉ

oauth controller ํ…Œ์ŠคํŠธ

  • ์„ฑ๊ณต ํ…Œ์ŠคํŠธ
    • oauth ๋งํฌ ๋ฐ˜ํ™˜ ์—ฌ๋ถ€
    • ํ† ํฐ ๋ฐœ๊ธ‰ ์—ฌ๋ถ€
    • ์—‘์„ธ์Šค ํ† ํฐ ์žฌ๋ฐœ๊ธ‰
    • ํšŒ์›ํƒˆํ‡ด
  • ์‹คํŒจ ํ…Œ์ŠคํŠธ
    • oauth ํƒ€์ž…์ด ์กด์žฌํ•˜์ง€ ์•Š๋Š” ๊ฒฝ์šฐ
    • ์ฐจ๋‹จ๋œ ํšŒ์›์ด ๋กœ๊ทธ์ธ ํ•  ๊ฒฝ์šฐ
    • ํƒˆํ‡ดํ•œ ํšŒ์›์ด ๋กœ๊ทธ์ธ ํ•  ๊ฒฝ์šฐ
    • ํœด๋ฉด ํšŒ์›์ด ๋กœ๊ทธ์ธ ํ•  ๊ฒฝ์šฐ

#๏ธโƒฃ์—ฐ๊ด€๋œ ์ด์Šˆ

#222

@Astin01
Test : oauth controller
1696782 
oauth ๋งํฌ ๋ฐ˜ํ™˜ ์—ฌ๋ถ€
ํ† ํฐ ๋ฐœ๊ธ‰ ์—ฌ๋ถ€
@Astin01 Astin01 added the test label Oct 6, 2024
@Astin01 Astin01 added this to the v1.2.0 milestone Oct 6, 2024
@Astin01 Astin01 requested a review from hyeonjaez October 6, 2024 12:38
@Astin01 Astin01 self-assigned this Oct 6, 2024
hyeonjaez
hyeonjaez reviewed Oct 6, 2024
View reviewed changes
src/test/java/solitour_backend/solitour/oauth/controller/OauthControllerTest.java
@AutoConfigureRestDocs
@Transactional
@SpringBootTest
class OauthControllerTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‹คํŒจ ํ…Œ์ŠคํŠธ๋Š” ์•ˆํ•ด๋„ ๋ ๊นŒ์š”..?

Astin01 added 3 commits October 8, 2024 16:20
@Astin01
Fix : ์œ ์ € ์ด๋ฏธ์ง€ ์ƒ์„ฑ ํ•„๋“œ ์ˆ˜์ •
fb65afe 
date -> datetime
@Astin01
Test : ์‹คํŒจ ํ…Œ์ŠคํŠธ
9d74c29 
oauth ํƒ€์ž…์ด ์กด์žฌํ•˜์ง€ ์•Š๋Š”๊ฒฝ์šฐ
์ฐจ๋‹จ๋œ ํšŒ์›์ผ ๊ฒฝ์šฐ
ํƒˆํ‡ดํ•œ ํšŒ์›์ผ ๊ฒฝ์šฐ
ํœด๋ฉด ํšŒ์›์ผ ๊ฒฝ์šฐ
@Astin01
Fix : ํœด๋ฉด ํšŒ์›์ผ ๋•Œ ์˜ˆ์ƒ๋˜๋Š” ์ƒํƒœ์ฝ”๋“œ ์ˆ˜์ •
4536d1a 
403-> 423
hyeonjaez
hyeonjaez previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@hyeonjaez hyeonjaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค

hyeonjaez
hyeonjaez approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@hyeonjaez hyeonjaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค

@Astin01 Astin01 merged commit 5786bff into develop Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyeonjaez hyeonjaez hyeonjaez approved these changes

Assignees

@Astin01 Astin01

Labels
test
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Astin01 @hyeonjaez