Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect revert behavior on testnet, but not on hardhat development network #646

Open
floomby opened this issue Mar 16, 2022 · 0 comments

Comments

@floomby
Copy link

floomby commented Mar 16, 2022

I have one contract which calls burnFrom in an erc20 contract and a reverts due to insufficient allowance. The revert is not being handle correctly. Getting this output:

      AssertionError: Expected transaction to be reverted
      + expected - actual

      -Transaction NOT reverted.
      +Transaction reverted.

If I can look in the block explorer and see that the transaction is failing: https://explorer.testnet.harmony.one/tx/0xe134e66922a2a9a8f87f774d930b90ef919234a3dcfccab62fd5e0b22a9842c6?activeTab=0

I am using harmony testnet as well as using the zeppelin uups contracts.

@floomby floomby changed the title Incorrect revert behavior only on testnet, but not on hardhad development network Incorrect revert behavior on testnet, but not on hardhat development network Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant