You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
After applying the fix for #261 and #266 (via #267), it appears that it prevents any channel from starring any messages when there is an allowed role configured.
This is because when evaluating the allowlist, we call function check_channel. It checks for self.whitelist, which contains both channel IDs and role IDs, and because there is a whitelisted role, it assumes that there are whitelisted channels as well, which there aren't, and returns False. When if any(..., not allowed_channel) is evaluated, any(..., not False ) evaluates to True and we don't highlight the message.
To Reproduce
Steps to reproduce the behavior:
Configure an allowed role.
Configure a denied channel (should be optional)
Have people with an allowed role star a message in the any non-denied channel.
Describe the bug
After applying the fix for #261 and #266 (via #267), it appears that it prevents any channel from starring any messages when there is an allowed role configured.
This is because when evaluating the allowlist, we call function
check_channel
. It checks forself.whitelist
, which contains both channel IDs and role IDs, and because there is a whitelisted role, it assumes that there are whitelisted channels as well, which there aren't, and returnsFalse
. Whenif any(..., not allowed_channel)
is evaluated,any(..., not False )
evaluates toTrue
and we don't highlight the message.To Reproduce
Steps to reproduce the behavior:
Expected behavior
The message to be highlighted.
Screenshots
![image](https://user-images.githubusercontent.com/6710854/138817459-a952a69f-e21e-400c-a992-4a587a04c5ec.png)
(Similar screenshot from #261)
The text was updated successfully, but these errors were encountered: