Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gscan warns about {{author}} on author-:slug.hbs templates #165

Closed
jameshome opened this issue Oct 19, 2018 · 4 comments
Closed

gscan warns about {{author}} on author-:slug.hbs templates #165

jameshome opened this issue Oct 19, 2018 · 4 comments
Labels

Comments

@jameshome
Copy link

I'm using default Ghost routing to have custom author pages for each author. gscan doesn't seem to parse these as author pages, so it is showing these as errors. Is there something different I should be doing to tell gscan about these custom author pages, or is this a bug?

@zce
Copy link

zce commented Oct 22, 2018

This problem also happened when {{author}} on partial templates as data context.

@zce
Copy link

zce commented Oct 22, 2018

This problem also happened when {{author}} on partial templates as data context.

Rule Report for v2.1.0:

! Must fix:
- error Replace the <code>{{author.cover_image}}</code> helper with <code>{{primary_author.cover_image}}</code> or <code>{{authors.[#].cover_image}}</code>
    Files: partials/site-cover.hbs

@kirrg001 kirrg001 self-assigned this Oct 22, 2018
@kirrg001
Copy link
Contributor

Thanks for the bug report 👍

Looks like this is caused by this line. We allow {{#author}} in author.hbs, but not in author-slug.hbs.

@kirrg001 kirrg001 removed their assignment Oct 22, 2018
@kirrg001 kirrg001 added the bug label Oct 22, 2018
@naz
Copy link
Contributor

naz commented Mar 27, 2019

This issue very closely related and will be solved as a part of #170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants