Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DifferentiableDensityModel out of AHMC #272

Open
torfjelde opened this issue Jul 15, 2021 · 2 comments
Open

Move DifferentiableDensityModel out of AHMC #272

torfjelde opened this issue Jul 15, 2021 · 2 comments

Comments

@torfjelde
Copy link
Member

The current implementation of the AbstractMCMC.jl-interface uses the

struct DifferentiableDensityModel{Tlogπ, T∂logπ∂θ} <: AbstractMCMC.AbstractModel
"Log-density. Maps `AbstractArray` to value of the log-density."
ℓπ::Tlogπ
"Gradient of log-density. Returns a tuple of `ℓπ` and the gradient evaluated at the given point."
∂ℓπ∂θ::T∂logπ∂θ
end

as the AbstractMCMC.AbstractModel type for this package. But such a model is useful elsewhere too, hence it's unfortunate that we tie to AHMC in this way.

Maybe this should go to AbstractMCMC.jl itself?

@yebai
Copy link
Member

yebai commented Jul 15, 2021

That sounds good to me. What do you think @cpfiffer @devmotion ?

@torfjelde
Copy link
Member Author

I made an issue for the "Maybe this should go to AbstractMCMC.jl?"-question in the AMCMC repo: TuringLang/AbstractMCMC.jl#81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants