Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove DensityModel? #108

Open
torfjelde opened this issue Dec 4, 2024 · 0 comments
Open

Can we remove DensityModel? #108

torfjelde opened this issue Dec 4, 2024 · 0 comments

Comments

@torfjelde
Copy link
Member

DensityModel isn't that useful now that we have LogDensityProblems.jl propagated through the ecosystem.

So should we just remove it?

The only downside I see here is that technically LogDensityProblems.jl requires implementing dimension, but this would mean that we can support models with varying dimensionality.

However, as long as the underlying sampler doesn't explicitly call dimension, we could just ignore this tbh 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant