Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Distributions 0.24 #24

Closed
mohamed82008 opened this issue Nov 13, 2021 · 3 comments
Closed

Support Distributions 0.24 #24

mohamed82008 opened this issue Nov 13, 2021 · 3 comments

Comments

@mohamed82008
Copy link
Member

Hi!

Is there any reason why this package requires Distributions 0.25? Would it be easy to support 0.24 as well?

@sethaxen
Copy link
Member

Unfortunately I don't think so. R* returns a PoissonBinomial distribution (see #7), which was broken until Distributions v0.25.4 (see JuliaStats/Distributions.jl#1345)

@devmotion
Copy link
Member

As @sethaxen said, the R* diagnostic requires Distributions 0.25. I had to make quite many changes in Distributions before R* could be added, e.g., it requires JuliaStats/Distributions.jl#1286 (the PR that @sethaxen mentioned is only required to actually work with the resulting distribution but not for creating it in this package 😄). So unfortunately, no, I don't think this package will support older versions of Distributions.

@mohamed82008
Copy link
Member Author

I see, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants