Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming XXXESSMethod to XXXAutocovMethod #60

Closed
sethaxen opened this issue Jan 10, 2023 · 1 comment
Closed

Renaming XXXESSMethod to XXXAutocovMethod #60

sethaxen opened this issue Jan 10, 2023 · 1 comment

Comments

@sethaxen
Copy link
Member

All of our AbstractESSMethods really just define different approaches for estimating the mean autocovariance of demeaned samples, whereas optional arguments, keyword arguments, and other methods (see #53) are used to define different ESS variants (ESS of different estimands, ESS with preprocessing, splitting vs unsplit, maxlag, etc).

For clarity, I suggest we rename AbstractESSMethod to AbstractAutocovMethod, following a similar pattern for the subtypes. We can rename the method kwarg passed to ess to autocov_method.

@sethaxen
Copy link
Member Author

Fixed by #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant