Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-reproducible step sizes #1924

Merged
merged 2 commits into from
Dec 24, 2022
Merged

Fix non-reproducible step sizes #1924

merged 2 commits into from
Dec 24, 2022

Conversation

devmotion
Copy link
Member

Might be sufficient to fix #1923.

@torfjelde torfjelde mentioned this pull request Dec 24, 2022
@torfjelde
Copy link
Member

Sorry, didn't see this before making my own 😅

Should we maybe add a short test? E.g.

    @turing_testset "reproducibility" begin
        alg = NUTS(1000, 0.8)
        res1 = sample(StableRNG(123), gdemo_default, alg, 1000)
        res2 = sample(StableRNG(123), gdemo_default, alg, 1000)
        @test Array(res1) == Array(res2)
    end

to test/inference/hmc.jl?

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a test would be nice:)

@coveralls
Copy link

coveralls commented Dec 24, 2022

Pull Request Test Coverage Report for Build 3770976411

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 3663908235: 0.0%
Covered Lines: 0
Relevant Lines: 1432

💛 - Coveralls

@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (9e6494f) compared to base (61b06f6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1924   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1432    1432           
======================================
  Misses       1432    1432           
Impacted Files Coverage Δ
src/inference/hmc.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yebai yebai merged commit f9353f0 into master Dec 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the dw/rng branch December 24, 2022 18:15
@yebai
Copy link
Member

yebai commented Dec 24, 2022

thanks @devmotion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StableRNG in Turing is not yielding reproducible output
4 participants