Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n and "skip tutorial" #4

Open
guidouil opened this issue Oct 3, 2014 · 2 comments
Open

i18n and "skip tutorial" #4

guidouil opened this issue Oct 3, 2014 · 2 comments

Comments

@guidouil
Copy link
Collaborator

guidouil commented Oct 3, 2014

Hi Mizzao,
First, thanks for your great package, I'm using it on gotlog.in (question mark in the nav bar) and it's great 👍
Now my questions 🎱
are you planning to integrate the mutli language with i18n ?
https://atmospherejs.com/tap/i18n

And also (I hate when people ask 2 questions in 1 issue ^^ ).
Is there a way in the tutorial to have the close button (x) on top right of the tutorial window ?

And also, the annimation was not displaying ok on smartphones so I forced the size and position. thanks for your "positioned" class :)

.positioned {
max-width: 350px;
left: 10px!important;
margin-left: 0!important;
}

@mizzao
Copy link
Member

mizzao commented Oct 5, 2014

Hi @guidouil, I would happily accept a PR that has a weak dependency on that (if it's the best option for i18n right now) and uses it to display text.

Having the close button is a reasonable request, it would probably trigger a new onClose callback or something.

By forcing the size/position, you mean it doesn't animate anymore, right?

@guidouil
Copy link
Collaborator Author

guidouil commented Oct 5, 2014

Ok for the PR, will do.
I would like the closing in the config, showCloseButton: true
Yes it disables the animation =( maybe it would be better only in mobile but I don't know how to do it in css.
You can close this "issue".
Thanks for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants