Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Support Issue #5

Open
Lisias opened this issue Sep 6, 2022 · 5 comments
Open

General Support Issue #5

Lisias opened this issue Sep 6, 2022 · 5 comments
Assignees
Labels
support support (no bug)

Comments

@Lisias
Copy link
Contributor

Lisias commented Sep 6, 2022

For random complains with or without merit. :)

@Lisias Lisias self-assigned this Sep 6, 2022
@Lisias Lisias added the support support (no bug) label Sep 6, 2022
@Lisias
Copy link
Contributor Author

Lisias commented Sep 6, 2022

Fellow Kerbonaut Merlin1809 reported that TSC-Frameworks is not working for him.

I build a quick test bed using:

  • KSP 1.12.3 + DLCs
  • ModuleManager (my fork, but it really doesn't matter - it mimics the Forum one even on the bugs)
  • Latest TweakScale (2.4.6.16 at this moment)
  • Latest TweakScale Companion for Frameworks (0.3.0.0 beta at this moment)
  • Latest Waterfall (0.9.0 at this moment)
  • Latest Stock Waterfall Effects (0.7.0 at this moment)

And found no obvious changes - even the bug on reverting to launch (where the plumes scales back to default) are there.

screenshot72

I need more information (perhaps he was using the 0.2.0.0? O forgot the pre-release flag on 0.3.0.0)

@Lisias
Copy link
Contributor Author

Lisias commented Sep 7, 2022

More about the issue on the last post, the thing apparently is happening only on the Panther engine. However, it's working for me on the same rig used above.

screenshot73

@Lisias
Copy link
Contributor Author

Lisias commented Feb 8, 2023

On Forum, AccidentalDissassembly reported a weird issue involving Waterfall.

Something seems to be going haywire between the Waterfall companion with the newest .23 tweakscale - sorry, full log was much too large to share due to tens of thousands of the following exception; I think the relevant exception is:

[EXC 21:28:42.962] NullReferenceException: TweakScale not found!
    TweakScaleCompanion.Frameworks.Waterfall.Integrator.Implementation..ctor (Part part, TweakScaleCompanion.Frameworks.Waterfall.Integrator.Listener listener) (at <77d418637add4e0586e796f77a2cd3f5>:0)
    System.Reflection.MonoCMethod.InternalInvoke (System.Object obj, System.Object[] parameters) (at <9577ac7a62ef43179789031239ba8798>:0)
    Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
    System.Reflection.MonoCMethod.InternalInvoke (System.Object obj, System.Object[] parameters) (at <9577ac7a62ef43179789031239ba8798>:0)
    System.Reflection.MonoCMethod.DoInvoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <9577ac7a62ef43179789031239ba8798>:0)
    System.Reflection.MonoCMethod.Invoke (System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <9577ac7a62ef43179789031239ba8798>:0)
    System.Reflection.ConstructorInfo.Invoke (System.Object[] parameters) (at <9577ac7a62ef43179789031239ba8798>:0)
    TweakScaleCompanion.Frameworks.Waterfall.TweakScalerWaterfallFX.InitModule () (at <ef4aca8115994959b9495b142422849a>:0)
    TweakScaleCompanion.Frameworks.Waterfall.TweakScalerWaterfallFX.Update () (at <ef4aca8115994959b9495b142422849a>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    KSPe.Util.Log.UnityLogDecorator:UnityEngine.ILogHandler.LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

That's weird, because the thingy would not had been patched without TweakScale and WaterfallFX being found installed.

There's something else happening on that machine. [edit or not, I had my share of weirdtities too ]

@Lisias
Copy link
Contributor Author

Lisias commented Feb 8, 2023

Nope. It's working fine for me. I build a quick test bed using:

  • KSP 1.12.5 + DLCs
  • ModuleManager (my fork, but it really doesn't matter - it mimics the Forum one even on the bugs)
  • Latest TweakScale (2.4.6.23 at this moment)
  • Latest TweakScale Companion for Frameworks (0.3.0.0 beta at this moment)
  • Latest Waterfall (0.9.0 at this moment)
  • Latest Stock Waterfall Effects (0.7.0 at this moment)

And the damned thing works:

screenshot10

@Lisias
Copy link
Contributor Author

Lisias commented Feb 9, 2023

About this mysterious happening from AccidentalDissassembly, the problem has just vanisbed from his rig but they graciously sent me their current logs et all so I can try to find some correlations.

I'm registering it here: mysterious_ts_waterfall_2023_02_08.zip

These possible "phantom TweakScale modules" (a possible explanation for the problem they got) may be related to these diagnosed "phantom Module Manager module" problem I got here on Forum.

@Lisias Lisias pinned this issue Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support support (no bug)
Projects
None yet
Development

No branches or pull requests

1 participant