Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Sampling MIS Is Incorrect when using Multiple Lights #11

Open
Twinklebear opened this issue Apr 2, 2022 · 0 comments
Open

Light Sampling MIS Is Incorrect when using Multiple Lights #11

Twinklebear opened this issue Apr 2, 2022 · 0 comments

Comments

@Twinklebear
Copy link
Owner

Opening this as a reminder to myself and note to others, the second MIS step for lights is not correct if there are multiple lights in the scene (e.g. here for DXR). It should "trace" the ray and try to intersect all the lights to see which is hit.

However it sounds like this can also be improved by just using the path continuation ray as the "second MIS" sample, rather than having to trace two shadow rays. Eventually I'll move ChameleonRT to use this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant