Fixed generating cache for loading options to handle objects (#1317)

* fix: Fixed generating cache for loading options to handle objects

Fixes #1316

* fix: Updated ts-loader instance hash in tests

* Added changelog and changed version in package.json

Author: timocov

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v9.2.0
+
+* [Fixed impossibility to have several instances of ts-loader with different compiler options](https://github.com/TypeStrong/ts-loader/issues/1316) - thanks @timocov
+
 ## v9.1.2
 
 * [Fix removed files handling in watch mode](https://github.com/TypeStrong/ts-loader/pull/1293) - thanks @gasnier

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ts-loader",
-  "version": "9.1.2",
+  "version": "9.2.0",
   "description": "TypeScript loader for webpack",
   "main": "index.js",
   "types": "dist",

src/index.ts

@@ -161,8 +161,10 @@ function getOptionsHash(loaderOptions: LoaderOptions) {
   const hash = crypto.createHash('sha256');
   Object.keys(loaderOptions).forEach(key => {
     const value = loaderOptions[key];
-    if (value) {
-      hash.update(key + value.toString());
+    if (value !== undefined) {
+      const valueString =
+        typeof value === 'function' ? value.toString() : JSON.stringify(value);
+      hash.update(key + valueString);
     }
   });
   return hash.digest('hex').substring(0, 16);

test/comparison-tests/aliasResolution/expectedOutput-4.2/output.txt

@@ -6,12 +6,12 @@ ERROR in app.ts
 ./app.ts 1:29-53
 [tsl] ERROR in app.ts(1,30)
       TS2307: Cannot find module 'components/myComponent' or its corresponding type declarations.
-ts-loader-default_b02295d909a3e7cf
+ts-loader-default_609318b4f68865d3
 
 ERROR in app.ts
 ./app.ts 2:30-55
 [tsl] ERROR in app.ts(2,31)
       TS2307: Cannot find module 'components/myComponent2' or its corresponding type declarations.
-ts-loader-default_b02295d909a3e7cf
+ts-loader-default_609318b4f68865d3
 
 webpack compiled with 2 errors

test/comparison-tests/aliasResolution/expectedOutput-4.2/patch0/output.txt

@@ -6,12 +6,12 @@ ERROR in app.ts
 ./app.ts 1:29-53
 [tsl] ERROR in app.ts(1,30)
       TS2307: Cannot find module 'components/myComponent' or its corresponding type declarations.
-ts-loader-default_b02295d909a3e7cf
+ts-loader-default_609318b4f68865d3
 
 ERROR in app.ts
 ./app.ts 2:30-55
 [tsl] ERROR in app.ts(2,31)
       TS2307: Cannot find module 'components/myComponent2' or its corresponding type declarations.
-ts-loader-default_b02295d909a3e7cf
+ts-loader-default_609318b4f68865d3
 
 webpack compiled with 2 errors

test/comparison-tests/allowJs-ts-check/expectedOutput-4.2/output.txt

@@ -7,7 +7,7 @@ ERROR in src/error2.js
 ./src/error2.js 4:9-12
 [tsl] ERROR in src/error2.js(4,10)
       TS2339: Property 'bar' does not exist on type 'Class2'.
-ts-loader-default_b02295d909a3e7cf
+ts-loader-default_609318b4f68865d3
  @ ./src/index.js 4:15-34
 
 webpack compiled with 1 error

test/comparison-tests/basic/expectedOutput-4.2/patch0/output.txt

@@ -6,6 +6,6 @@ ERROR in app.ts
 ./app.ts 3:12-24
 [tsl] ERROR in app.ts(3,13)
       TS2551: Property 'doSomething2' does not exist on type 'typeof externalLib'. Did you mean 'doSomething'?
-ts-loader-default_b02295d909a3e7cf
+ts-loader-default_609318b4f68865d3
 
 webpack compiled with 1 error

test/comparison-tests/colors/expectedOutput-4.2/output.txt

@@ -14,6 +14,6 @@ ERROR in app.ts
 ./app.ts 1:6-8
 [tsl] ERROR in app.ts(1,7)
       TS1005: ',' expected.
-ts-loader-default_b02295d909a3e7cf
+ts-loader-default_dda4fd88600de236
 
 webpack compiled with 2 errors

test/comparison-tests/colors/expectedOutput-transpile-4.2/output.txt

@@ -5,7 +5,7 @@ ERROR in app.ts
 ./app.ts 1:6-8
 [tsl] ERROR in app.ts(1,7)
       TS1005: ',' expected.
-ts-loader-default_66eeaf8be3a46130
+ts-loader-default_94b2ce3d1ca5f363
 
 ERROR in ./app.ts 2:1
 Module parse failed: Unexpected token (2:1)

test/comparison-tests/declarationDeps/expectedOutput-4.2/output.txt

@@ -5,6 +5,6 @@ ERROR in app.ts
 ./app.ts 2:6-11
 [tsl] ERROR in app.ts(2,7)
       TS2339: Property 'sayHi' does not exist on type 'typeof Hello'.
-ts-loader-default_b02295d909a3e7cf
+ts-loader-default_609318b4f68865d3
 
 webpack compiled with 1 error