Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the tests build by default? #146

Closed
FichteFoll opened this issue Dec 14, 2021 · 2 comments
Closed

Should the tests build by default? #146

FichteFoll opened this issue Dec 14, 2021 · 2 comments

Comments

@FichteFoll
Copy link
Contributor

I ran into this as I was updating the AUR package and needed to add downloads for gtest and its patch data. Should that be included in the default build at all and/or be disableable and is there a specific reason why gtest isn't looked up as a dependency first?
@FichteFoll
Copy link
Contributor Author 

[12-14][02:35:07] <@elibrokeit> the gtest wrap should be updated with `meson wrap update`
[12-14][02:35:42] <@elibrokeit> and then it should switch from subproject('...').get_variable('...') to proper dependencies

@arch1t3cht
Copy link
Member

gtest is looked up as a proper dependency with fallback now

@TypesettingTools TypesettingTools locked and limited conversation to collaborators Dec 31, 2024
@TypesettingTools TypesettingTools unlocked this conversation Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FichteFoll @arch1t3cht