Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer doesn't contain some languages #255

Closed
0tkl opened this issue Dec 31, 2024 · 2 comments · Fixed by #259
Closed

Installer doesn't contain some languages #255

0tkl opened this issue Dec 31, 2024 · 2 comments · Fixed by #259

Comments

@0tkl
Copy link
Contributor

0tkl commented Dec 31, 2024

In the installer of 3.4.0 or trunk build, some languages (like Korean and Chinese) are missing during installation, compared to r8942.

Screenshot-2024-12-31

The changes happened in a3ec466

@arch1t3cht
Copy link
Member

#ifdef UNOFFICIAL_LANGUAGES
; These languages are not shipped with InnoSetup by default and would need to be fetched from https://jrsoftware.org/files/istrans/

In theory this could be done in win-installer-setup.ps1, but it'd need a bit of extra work.

@CoffeeFlux
Copy link
Member

I can look at pulling those down for the installer, but yes, being a separate unsupported download is why they were disabled. It probably makes sense to try and get it working now.

This was referenced Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants