Output file has an additional blank line

[Ninelpienel]

Hey, when I use subdigest my output file has an additional blank line at the end. Various other programs that work with ass cannot handle this. Would be great if you could fix this.

Input:

Output:

[FichteFoll]

Subdigest doesn't do anything special in this regard, so this may be a result of the upstream ass library. Haven't tried to reproduce it yet, however.

Myaamori-Aegisub-Scripts/scripts/sub-digest/subdigest.py

Lines 565 to 566 in f2a52ee

	with open(args.output, 'w', encoding="utf-8-sig") as f:
	f.write(str(sub_obj))

[Funami580]

Just a guess, but perhaps this line?

https://github.com/chireiden/python-ass/blob/8243bd515531fa8e7180941bfc0fbac7fb24702f/ass/document.py#L152

[FichteFoll]

Yeah, that should be it. Called from dubdigest via

Myaamori-Aegisub-Scripts/scripts/sub-digest/subdigest.py

Lines 512 to 517 in f2a52ee

	def __str__(self):
	sio = io.StringIO()
	with warnings.catch_warnings():
	warnings.simplefilter("ignore", UserWarning)
	self.sub_file.dump_file(sio)
	return sio.getvalue()

Subdigest would also do better in using the dump_file method with the file it wants to write to directly instead of always writing to a StringIO first and then writing that. Catching the warning may be necessary for writing to stdout, though iirc we fixed overreporting with that warning a while ago. Could also be that it only occurs on Windows, though.

[FichteFoll]

Fixed in https://github.com/chireiden/python-ass/releases/tag/0.5.3.