Skip to content

Commit

Permalink
Ensure last ligature cell is updated
Browse files Browse the repository at this point in the history
  • Loading branch information
Tyriar committed Nov 4, 2024
1 parent 77885ed commit 7fab293
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions addons/addon-webgl/src/WebglRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,14 +314,6 @@ export class WebglRenderer extends Disposable implements IRenderer {
this._updateCursorBlink();
}

public registerCharacterJoiner(handler: (text: string) => [number, number][]): number {
return -1;
}

public deregisterCharacterJoiner(joinerId: number): boolean {
return false;
}

public renderRows(start: number, end: number): void {
if (!this._isAttached) {
if (this._coreBrowserService.window.document.body.contains(this._core.screenElement!) && this._charSizeService.width && this._charSizeService.height) {
Expand Down Expand Up @@ -510,14 +502,17 @@ export class WebglRenderer extends Disposable implements IRenderer {
cell = this._workCell;

// Null out non-first cells
for (x++; x < lastCharX; x++) {
for (x++; x <= lastCharX; x++) {
j = ((y * terminal.cols) + x) * RENDER_MODEL_INDICIES_PER_CELL;
this._glyphRenderer.value!.updateCell(x, y, NULL_CELL_CODE, 0, 0, 0, NULL_CELL_CHAR, 0, 0);
this._model.cells[j] = NULL_CELL_CODE;
// Don't re-resolve the cell color since multi-colored ligature backgrounds are not
// supported
this._model.cells[j + RENDER_MODEL_BG_OFFSET] = this._cellColorResolver.result.bg;
this._model.cells[j + RENDER_MODEL_FG_OFFSET] = this._cellColorResolver.result.fg;
this._model.cells[j + RENDER_MODEL_EXT_OFFSET] = this._cellColorResolver.result.ext;
}
x--; // Go back to the previous update cell for next iteration
}
}
}
Expand Down

0 comments on commit 7fab293

Please sign in to comment.