Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hurl Rewrite Project #112

Closed
wants to merge 3 commits into from
Closed

Hurl Rewrite Project #112

wants to merge 3 commits into from

Conversation

U-C-S
Copy link
Owner

@U-C-S U-C-S commented Apr 3, 2024

An attempt at rewriting Hurl.BrowserSelector Project

Might take some time for this to progress

@U-C-S U-C-S added this to the v0.9 milestone Apr 3, 2024
WindowStartupLocation="CenterScreen"
mc:Ignorable="d">
<Grid>
<ui:TitleBar Title="Hurl [BETA]" Grid.ColumnSpan="3" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgently recommend not to use the same Grid idea

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it makes everything way too complicated. You need to remember to put everything in the middle, and you will never have a scrollviewer that touches the sides. The same effect can be achieved with MaxWidth of the content.

@spa5k
Copy link

spa5k commented Apr 18, 2024

IMO we should also add some automation, like automatically opening the site in same browser as it was previously opened with some TTL, can use SQLite or something of sorts.

@Jay-o-Way
Copy link
Contributor

I think it would be a good idea to make some docs with specifications first. That's easy to discuss and when that's clear and worked out, it'll make the actual building much easier.

@U-C-S
Copy link
Owner Author

U-C-S commented Apr 19, 2024

I think it would be a good idea to make some docs with specifications first. That's easy to discuss and when that's clear and worked out, it'll make the actual building much easier.

You are right. Will do that.

@U-C-S U-C-S linked an issue May 16, 2024 that may be closed by this pull request
12 tasks
@U-C-S U-C-S removed this from the v0.9 milestone May 16, 2024
@Jay-o-Way
Copy link
Contributor

I think there are a number of important decisions to be made, before even starting to commit a rewrite like this. For example:

  • Create documentation
  • Decide about WPF-UI (latest version) versus WinUI3
  • Decide about a one-window UX solution, where current windows act as Pages
  • Pull Requests and branches
  • Investigate signing binaries
  • and much more

You could use Discussions to ask for user feedback.

@U-C-S
Copy link
Owner Author

U-C-S commented Jun 15, 2024

You are right. I'm putting this on-hold for a Little while. (#120 (comment)). Will concentrate on Hurl Settings for now, and also minor improvements to the main app as well. Will come back to this, once I have a concrete plan here. Thanks for the frequent feedback.

I'm already making few plans and notes on ideas, Which I will put them out later for discussion. Mostly on the technical side, like whether or not, if I should migrate Rule matching code into Launcher project etc.

@U-C-S U-C-S closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hurl Rewrite Project
4 participants