Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: replace ListView → NavigationView #168

Open
Jay-o-Way opened this issue Oct 17, 2024 · 4 comments
Open

Task: replace ListView → NavigationView #168

Jay-o-Way opened this issue Oct 17, 2024 · 4 comments
Assignees
Labels
Feature Enhancement Update existing feature
Milestone

Comments

@Jay-o-Way
Copy link
Contributor

Willing to work on this :)
Idea: merge page About with page (general) Settings, for convenience.

References:
https://learn.microsoft.com/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.controls.navigationview?view=windows-app-sdk-1.6
https://learn.microsoft.com/windows/apps/design/controls/navigationview

@U-C-S
Copy link
Owner

U-C-S commented Oct 18, 2024

Yes please

@U-C-S U-C-S added the Feature Enhancement Update existing feature label Oct 18, 2024
@U-C-S U-C-S added this to the v0.10 milestone Oct 18, 2024
@Jay-o-Way
Copy link
Contributor Author

It's not that simple. Navigation is a complicated system, with classes and files. Best thing to do is create things (like files) from scratch and only copy/paste the essentials, but this means changes will become large quickly...

@U-C-S
Copy link
Owner

U-C-S commented Oct 31, 2024

I played around this a bit back when I was implementing the existing system. I couldn't figure out how to use NavigationView from the docs and samples, looked into couple of other WinUI based OSS software, all of them had their own implementations upon listview, etc.

Anyway I will take a look, once again. If it doesn't work out, Have to just polish the existing ListView impl.

@Jay-o-Way
Copy link
Contributor Author

Yeah, yesterday I started to try the long and large path, creating new blank pages et cetera. At least the first page loads, so that's a small win for now. I'll let you know how things progress...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Update existing feature
Projects
None yet
Development

No branches or pull requests

2 participants